Skip to content

ci: pin third-party GitHub Actions to commit SHAs - #892

Merged
petercorke merged 2 commits into
mainfrom
ci/pin-third-party-actions
Oct 23, 2026
Merged

petercorke merged 2 commits into
mainfrom
ci/pin-third-party-actions

Conversation

@petercorke

Copy link
Copy Markdown
Owner

What

Pins the six third-party GitHub Actions used in RTB's workflows to full commit SHAs, with the version in a comment. Seven references in five files. This is the RTB pilot of petercorke/rvc-ecosystem#24, which has the reasoning and the survey of the other repos.

A tag such as @v6 can be moved by the action's author, or by anyone who takes over their account, and the workflow then runs that code with the repository's permissions. release.yml publishes to PyPI, so it matters most there. Codacy reports it (7 findings).

Action Was Now
amannn/action-semantic-pull-request @v6 48f2562… v6.1.1
codecov/codecov-action @v7 303a32d… v7.1.1
dependabot/fetch-metadata @v3 25dd0e3… v3.1.0
googleapis/release-please-action @v5 45996ed… v5.0.0
pypa/cibuildwheel @v4.2.1 e090b81… v4.2.1
pypa/gh-action-pypi-publish (twice) @release/v1 (a moving branch) 7245906… v1.14.3

Same code as before

Each SHA is the commit that its tag, or for the PyPI action the branch head, points to today. I found each with the GitHub API, following an annotated tag to its commit, and checked that a version tag points at that same commit. So the code that runs is unchanged.

Upkeep

Dependabot's github-actions ecosystem is already enabled for this repo, and it updates a pinned SHA together with its version comment. GitHub's own actions/* stay on tags.

Not tested

release.yml and release-rtb-data.yml cannot be run without a release, so the SHAs there are verified by the API check above and not by running them. ci.yml (codecov) and the PR title check (amannn) run on this PR.

🤖 Generated with Claude Code

A tag can be moved by the action's author, or by anyone who takes over their
account, and the workflow then runs that code with the repository's
permissions.  release.yml publishes to PyPI, so it matters most there.

Each SHA is the commit that the tag pointed to when this was written, found
with the GitHub API (following an annotated tag to its commit), and the
version is in a comment.  pypa/gh-action-pypi-publish was on the moving branch
release/v1 and is now on v1.14.3, which is its head.  Dependabot's
github-actions ecosystem is already enabled and updates a pinned SHA together
with its version comment.  GitHub's own actions/* stay on tags.

See petercorke/rvc-ecosystem#24.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@petercorke
petercorke enabled auto-merge (squash) October 22, 2026 23:50
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (0e37549) to head (b8593f0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #892   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        146     146           
  Lines      16684   16684           
=====================================
  Misses     16684   16684           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petercorke
petercorke merged commit d677acb into main Oct 23, 2026
23 checks passed
@petercorke
petercorke deleted the ci/pin-third-party-actions branch October 23, 2026 00:49
petercorke added a commit to petercorke/pgraph-python that referenced this pull request Oct 31, 2026
- Delete posegraph.py, a 2020 prototype in the repository root that nothing
  uses: it imports the deprecated UVertex, has a stub method and debug prints,
  and needs itertools.pairwise (Python 3.10) in a package that supports 3.9.
  The Robotics Toolbox has the real PoseGraph.
- examples/create_json.py: pop('dgoal', None) instead of a bare except.
- Pin the two remaining third-party GitHub Actions to commit SHAs with the
  version in a comment, as RTB did in petercorke/robotics-toolbox-python#892:
  codecov/codecov-action v7.1.1 and dependabot/fetch-metadata v3.1.0.  They are
  the commits that @v7 and @V3 point to today, so what runs is unchanged.
  GitHub's own actions/* stay on tags, and Dependabot updates a pinned SHA with
  its comment.
- Ignore build/ as well as docs/build and dist/.

Part of #23.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant